Skip to content

feat: add traits field to channel object asyncapi/spec#1220- #1193 - #5709

Open
ivangsa wants to merge 3 commits into
asyncapi:masterfrom
ivangsa:feat/channel-traits
Open

feat: add traits field to channel object asyncapi/spec#1220- #1193#5709
ivangsa wants to merge 3 commits into
asyncapi:masterfrom
ivangsa:feat/channel-traits

Conversation

@ivangsa

@ivangsa ivangsa commented Aug 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This proposal adds traits to the Channel Object, closing the only gap left after Operation Traits and Message Traits. It standardizes channel binding composition and removes the combinatorial explosion of pre-built per-combination channels.

Related issue(s)

fixes asyncapi/spec#1220

Summary by CodeRabbit

  • Documentation
    • Added a reference entry for specification version 3.2.0.
    • Updated the documentation navigation to link to the 3.2.0 specification and display the correct version heading.

@ivangsa
ivangsa requested a review from bandantonio as a code owner August 18, 2026 10:46
@github-project-automation github-project-automation Bot moved this to To Be Triaged in Website - Kanban Aug 18, 2026
@netlify

netlify Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 78bc4c6
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6a843e8b6450eb00083a96ed
😎 Deploy Preview https://deploy-preview-5709--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e2c706d9-402b-42eb-906b-ac5a265529d4

📥 Commits

Reviewing files that changed from the base of the PR and between 8aaf37b and 78bc4c6.

📒 Files selected for processing (1)
  • cypress/fixtures/docsSections.json

Included review availability: Your plan includes up to 4 reviews per rolling hour; 2 remain after this review.

📝 Walkthrough

Walkthrough

The specification explorer now declares version 3.2.0. The documentation fixture now links to the 3.2.0 specification page and displays the 3.2.0 heading.

Changes

Specification version metadata

Layer / File(s) Summary
Declare and reference version 3.2.0
markdown/docs/reference/specification/v3.2.0-explorer.md, cypress/fixtures/docsSections.json		 Adds the Visualizer declaration for version 3.2.0. Updates the documentation URL and heading from 3.1.0 to 3.2.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 78bc4

This change adds channel traits to the specification documentation and updates the related documentation fixture; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: bandantonio, princerajpoot20, anshgoyalevil

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims a Channel Object traits change, but the changes only update 3.2.0 documentation references. Update the title to describe the 3.2.0 documentation updates, or include the claimed Channel Object traits implementation.
Linked Issues check ⚠️ Warning The changes do not add channel traits, Channel Trait Objects, schemas, parser support, or related fixtures required by issue #1220. Implement the coding requirements from issue #1220, including specification, schemas, parser support, and tests.
Out of Scope Changes check ⚠️ Warning The Visualizer documentation entry and docsSections version update are unrelated to the channel traits requirements in issue #1220. Remove unrelated documentation changes or link them to an issue that requires the 3.2.0 documentation updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asyncapi-bot

asyncapi-bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 61
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5709--asyncapi-website.netlify.app/

@asyncapi-bot
asyncapi-bot requested a review from CBID2 August 18, 2026 11:14
@sonarqubecloud

sonarqubecloud Bot commented Aug 18, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner
@TRohit20 TRohit20 Awaiting requested review from TRohit20 TRohit20 is a code owner
@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner
@anshgoyalevil anshgoyalevil Awaiting requested review from anshgoyalevil anshgoyalevil is a code owner
@princerajpoot20 princerajpoot20 Awaiting requested review from princerajpoot20 princerajpoot20 is a code owner
@bandantonio bandantonio Awaiting requested review from bandantonio bandantonio is a code owner
@derberg derberg Awaiting requested review from derberg derberg is a code owner
@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner
@sambhavgupta0705 sambhavgupta0705 Awaiting requested review from sambhavgupta0705 sambhavgupta0705 is a code owner
@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner
@CBID2 CBID2 Awaiting requested review from CBID2

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Website - Kanban
Status: To Be Triaged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Channel object have no Traits field (RFC Stage 1)

2 participants

@ivangsa @asyncapi-bot